Clean up public API a bit#58076
Conversation
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
| } | ||
|
|
||
| /** @internal */ | ||
| export type FlowType = Type | IncompleteType; |
There was a problem hiding this comment.
Probably I should have noticed this in #58036, but we already make public all of the other types.
There was a problem hiding this comment.
| isDefinition?: boolean; | ||
| } | ||
|
|
||
| /** @internal */ |
There was a problem hiding this comment.
Need to revert this one; it's used :( https://github.com/search?q=%2Fts%5C.SymbolDisplayPartKind%2F&type=code
| kind: string; | ||
| } | ||
|
|
||
| /** @internal */ |
There was a problem hiding this comment.
| } | ||
|
|
||
| /** @internal */ | ||
| export const enum JsxFlags { |
There was a problem hiding this comment.
This is used once, but I feel like this shouldn't be exported: https://github.com/search?q=%2F%5Cbts%5C.JsxFlags%2F+%28language%3ATypeScript+OR+language%3AJavaScript%29&type=code
| } | ||
|
|
||
| /** @internal */ | ||
| export interface CheckJsDirective extends TextRange { |
There was a problem hiding this comment.
| declarationTransformers: readonly TransformerFactory<SourceFile | Bundle>[]; | ||
| } | ||
|
|
||
| export interface SourceMapSpan { |
There was a problem hiding this comment.
This looked bad but these are all forks of ourselves: https://github.com/search?q=%2F%5Cbts%5C.SourceMapSpan%2F+%28language%3ATypeScript+OR+language%3AJavaScript%29&type=code
|
|
||
| /** @internal */ | ||
| // dprint-ignore | ||
| export const enum InferencePriority { |
There was a problem hiding this comment.
| } | ||
|
|
||
| export interface HostConfiguration { | ||
| interface HostConfiguration { |
There was a problem hiding this comment.
| } | ||
|
|
||
| export interface PendingErrorCheck { | ||
| interface PendingErrorCheck { |
There was a problem hiding this comment.
| WatchOptions, | ||
| } from "./_namespaces/ts"; | ||
|
|
||
| export interface CompressedData { |
There was a problem hiding this comment.
jakebailey
left a comment
There was a problem hiding this comment.
Doing a full search, it seems like a lot of this is somehow used externally :(
| } | ||
|
|
||
| /** @internal */ | ||
| export interface PerformanceEvent { |
There was a problem hiding this comment.
| } | ||
|
|
||
| /** @internal */ | ||
| export interface IncompleteCompletionsCache { |
There was a problem hiding this comment.
| Imports = "imports", | ||
| } | ||
|
|
||
| export const enum OutputFileType { |
There was a problem hiding this comment.
Used but by a very, very old project https://github.com/search?q=%2F%5Cbts%5C.OutputFileType%2F+%28language%3ATypeScript+OR+language%3AJavaScript%29&type=code
| } | ||
|
|
||
| /** @internal */ | ||
| export const enum ScriptElementKindModifier { |
There was a problem hiding this comment.
| } | ||
|
|
||
| /** @internal */ | ||
| export interface InlayHintsContext { |
There was a problem hiding this comment.
Following #58036, I made a script to process our public API and find elements which are unreferenced.
There's a lot more than this, including:
I can also make some of that internal (not the server protocol of course), if that's desirable.