ci: fix pullapprove to match hidden files and directories#46520
Closed
devversion wants to merge 1 commit into
Closed
ci: fix pullapprove to match hidden files and directories#46520devversion wants to merge 1 commit into
devversion wants to merge 1 commit into
Conversation
devversion
added
area: build & ci
Member
Author
|
Tested and verified with the |
gkalpak
reviewed
Jun 27, 2022
devversion
force-pushed
the
pullapprove-dot-files
branch
2 times, most recently
from
d9b2405 to
2bc25ba
Compare
devversion
added
action: merge
dylhunn
added
action: cleanup
Contributor
|
Mind doing a quick rebase? |
After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: angular/dev-infra#642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13
devversion
force-pushed
the
pullapprove-dot-files
branch
from
2bc25ba to
68bbbd9
Compare
devversion
added
action: merge
Contributor
|
This PR was merged into the repository by commit 0775332. |
dylhunn
pushed a commit
that referenced
this pull request
Jun 28, 2022
After some testing, and experiences in other PRs, it looks like Pullapprove does not match hidden files/directories as their globbing logic `wcmatch` does not enable the `DOTGLOB` flag. See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect this with: angular/dev-infra#642. https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13 PR Close #46520
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some testing, and experiences in other PRs, it looks like Pullapprove
does not match hidden files/directories as their globbing logic
wcmatchdoes not enable the
DOTGLOBflag.See: https://facelessuser.github.io/wcmatch/glob/. ng-dev is updated to reflect
this with: angular/dev-infra#642.
Source of pullapprove: https://github.com/dropseed/pullapprove/blob/8a26c19346680cfcb8a635707257a74ee56b91ca/pullapprove/context/functions.py#L13