test(cli): use ports map for quiet logging test #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knagaitsev
requested review from
alexander-akait and
hiroppy
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2247 +/- ##
========================================
Coverage ? 93.9%
========================================
Files ? 34
Lines ? 1279
Branches ? 367
========================================
Hits ? 1201
Misses ? 71
Partials ? 7Continue to review full report at Codecov.
|
hiroppy
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Use ports map instead of hard-coded port 8080. Note that the
cliports-map value already existed, just wasn't being used.Breaking Changes
N/A
Additional Info