Skip to content

14662 aria selector slowness #14784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
fpereira1 wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

14662 aria selector slowness #14784

fpereira1 wants to merge 11 commits into from
+108 −52

Conversation

@fpereira1
Copy link
Member

@fpereira1 fpereira1 commented Sep 25, 2025 •
edited
Loading

closes: #14662

adds a browser.isSafari

TBD

@fpereira1 fpereira1 marked this pull request as draft September 25, 2025 09:53
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 25, 2025 •
edited
Loading

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14784

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14784

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14784

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14784

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14784

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14784

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14784

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14784

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14784

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14784

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14784

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14784

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14784

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14784

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14784

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14784

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14784

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14784

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14784

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14784

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14784

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14784

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14784

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14784

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14784

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14784

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14784

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14784

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14784

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14784

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14784

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14784

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14784

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14784

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14784

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14784

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14784

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14784

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14784

commit: dc36669

@fpereira1 fpereira1 mentioned this pull request Sep 25, 2025
Open
1 task
This was referenced Sep 25, 2025
Closed
Merged
Closed
christian-bromann
christian-bromann reviewed Sep 27, 2025
View reviewed changes
packages/webdriverio/src/utils/findStrategy.ts
Comment on lines +209 to +210
using = 'aria'
value = label
Copy link
Member

@christian-bromann christian-bromann Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this using the accessibility selector in Bidi? Can we query accessibility roles AND labels here? I think it would be better to use the isBidi flag in this case.

Copy link
Member Author

@fpereira1 fpereira1 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. isBidi might be the way to go here. Will update

Copy link
Member Author

@fpereira1 fpereira1 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been done

@christian-bromann
Copy link
Member

christian-bromann commented Nov 23, 2025

@fpereira1 I think we can move forward with this once the merge conflict is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aria/ selector slowness in finding elements

2 participants

@fpereira1 @christian-bromann