Skip to content

feat(isPostalCode): Add CN (China) postalCode validator and test.#1534

Merged
profnandaa merged 3 commits intovalidatorjs:masterfrom
httpsbao:master
Nov 29, 2020
Merged

feat(isPostalCode): Add CN (China) postalCode validator and test.#1534
profnandaa merged 3 commits intovalidatorjs:masterfrom
httpsbao:master

Conversation

@httpsbao
Copy link
Copy Markdown
Contributor

@httpsbao httpsbao commented Nov 28, 2020

Hello, I add CN (China) postalCode validator and test.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2020 •
edited
Loading

Codecov Report

Merging #1534 (727cdf0) into master (7ef0f25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           98        98           
  Lines         1763      1763           
=========================================
  Hits          1763      1763
Impacted Files Coverage Δ
src/lib/isPostalCode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef0f25...727cdf0. Read the comment docs.

tux-tn
tux-tn requested changes Nov 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contrib ! LGTM for most part 🎉
Just a little request: Can you discard your changes to auto-generated files ( index.js, validator.js and validator.min.js )

@httpsbao
discard changes to auto-generated files
727cdf0 
(index.js, validator.js,validator.min.js)
httpsbao
httpsbao commented Nov 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@httpsbao httpsbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more changes in index.js, validator.js and validator.min.js

@httpsbao
Copy link
Copy Markdown
Contributor Author

httpsbao commented Nov 28, 2020 •
edited
Loading

Thank you for your contrib ! LGTM for most part 🎉
Just a little request: Can you discard your changes to auto-generated files ( index.js, validator.js and validator.min.js )

@tux-tn

Thankyou, done!

profnandaa
profnandaa approved these changes Nov 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@profnandaa profnandaa merged commit 0f8e597 into validatorjs:master Nov 29, 2020
@profnandaa profnandaa mentioned this pull request Nov 30, 2020
Merged
This was referenced Mar 12, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tux-tn tux-tn tux-tn requested changes

@profnandaa profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@httpsbao @profnandaa @tux-tn