Skip to content

refactor(isDate): add strictMode and prevent mixed delimiters#1402

Merged
profnandaa merged 2 commits intovalidatorjs:masterfrom
tux-tn:fix/isDate
Sep 20, 2020
Merged

refactor(isDate): add strictMode and prevent mixed delimiters#1402
profnandaa merged 2 commits intovalidatorjs:masterfrom
tux-tn:fix/isDate

Conversation

@tux-tn
Copy link
Copy Markdown
Member

@tux-tn tux-tn commented Aug 8, 2020

Hello,

I made some changes to isDate to allow for more flexibility.

  • Add strictMode to enforce strict comparison between input and format. In strictMode Date objects, inputs with a different delimiter or string format are disallowed.
  • Disallow validating inputs with mixed delimiters (Fixes Bug in Date validation, isDate() function #1395 )
  • Allow passing custom delimiters list
  • This PR is backward compatible with old format isDate(input, format)

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2020 •
edited
Loading

Codecov Report

Merging #1402 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         1248      1257    +9     
=========================================
+ Hits          1248      1257    +9
Impacted Files Coverage Δ
src/lib/isDate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed86b0a...1f9833e. Read the comment docs.

@tux-tn
Copy link
Copy Markdown
Member Author

tux-tn commented Aug 8, 2020

strictModeis based on @ezkemboi idea in #1395 but with few changes. After some research, i can't find a standard date format with mixed delimiters and i don't think that allowing it in #1270 was purposely. For this reason strictMode intent here is to prevent validating inputs different from format.

validator.isDate('2020-05-02', { format: 'YYYY/MM/DD', strictMode: true}); /// returns false
validator.isDate(new Date(), { format: 'YYYY/MM/DD', strictMode: true}); // returns false

@ezkemboi
Copy link
Copy Markdown
Member

ezkemboi commented Aug 8, 2020

@tux-tn thanks for working on this.
Cc. @profnandaa

profnandaa
profnandaa approved these changes Sep 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the good work on this. I'm okay at some point down the line, making strictMode = true the default -- but for now, this is okay to maintain b/c.

@profnandaa profnandaa merged commit c94bfde into validatorjs:master Sep 20, 2020
@profnandaa profnandaa mentioned this pull request Nov 29, 2020
Merged
This was referenced Mar 12, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in Date validation, isDate() function

3 participants

@tux-tn @ezkemboi @profnandaa