Fix JsonSerializer example in reference guide #30329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you follow the docs writing custom json serializer, it throws an exception "JsonGenerationException". Of course, if there is an existing Json Generator, it is applicable code, but users (including myself) who usually follow docs are more likely to write the code first. Therefore, I think that the text should be modified as an example with the addition of JsonGenerator.writeStartObject()/writeEndObject() or a separate notice should exist for that part.
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@PPakSang you are correct and that example is wrong. You can see below that is rewritten to use |
snicoll
added
type: documentation
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Mar 19, 2022
snicoll
added a commit
that referenced
this pull request
Mar 19, 2022
Member
|
@PPakSang thank you for making your first contribution to Spring Boot. |
Contributor
Author
|
I was worried that I said something inaccurate because it was my first PR but it works. Thank you for the explanation. I'm really interested in Spring-boot project!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you follow the docs writing custom json serializer, it throws an exception "JsonGenerationException". Of course, if there is an existing Json Generator, it is applicable code, but users (including myself) who usually follow docs are more likely to write the code first. Therefore, I think that the text should be modified as an example with the addition of JsonGenerator.writeStartObject()/writeEndObject() or a separate notice should exist for that part.