Skip to content

fix Reproducible Build issue#2642

Merged
TimvdLippe merged 1 commit into
mockito:mainfrom
hboutemy:patch-1
May 16, 2022
Merged

fix Reproducible Build issue#2642
TimvdLippe merged 1 commit into
mockito:mainfrom
hboutemy:patch-1

Conversation

@hboutemy

Copy link
Copy Markdown
Contributor

see https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/mockito/mockito-core/README.md

release 4.5.1 has only 1 cause of non-reproducible bits: unix group permission on files

with that little change, next release should be 100% reproducible as reproduced by independant people

@codecov-commenter

codecov-commenter commented May 16, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2642 (0e1c501) into main (4629ed8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2642   +/-   ##
=========================================
  Coverage     86.24%   86.24%           
- Complexity     2760     2763    +3     
=========================================
  Files           314      314           
  Lines          8280     8280           
  Branches       1031     1029    -2     
=========================================
  Hits           7141     7141           
  Misses          872      872           
  Partials        267      267           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4629ed8...0e1c501. Read the comment docs.

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@TimvdLippe
TimvdLippe merged commit 0a7fb04 into mockito:main May 16, 2022
@hboutemy
hboutemy deleted the patch-1 branch May 18, 2022 06:38
@hboutemy

Copy link
Copy Markdown
Contributor Author

FYI, to day I rebuilt 4.6.0 release and Mockito and got a perfect reproducibility!
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/mockito/mockito-core/mockito-core-4.6.0.buildcompare

nice work, it's the first Gradle rebuild of an OSS release that was fully confirmed!
I hope it will be followed by a long list of other projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants