Fix RuntimeTypeAdapterFactory depending on internal Streams class#1959
Merged
eamonnmcmanus merged 3 commits intoSep 18, 2021
Conversation
Marcono1234
force-pushed
the
marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies
branch
from
September 11, 2021 04:22
bb6ce33 to
097e196
Compare
eamonnmcmanus
requested changes
Sep 13, 2021
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
Member
There was a problem hiding this comment.
Thanks! I guess we'll see whether the deploy configuration works the next time we release.
eamonnmcmanus
approved these changes
Sep 18, 2021
Marcono1234
deleted the
marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies
branch
September 18, 2021 00:42
This was referenced Jul 23, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1931
Additionally makes gson-extras a Maven module of gson-parent and cleans up its POM.
Deploying for gson-extras is disabled, hopefully this is respected by the Maven Release Plugin.