Make sure that a LongPressDraggable doesn't crash in 0x0 environment #180408
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a test to ensure LongPressDraggable doesn't crash in a zero-size environment. The test correctly sets up the scenario with a zero-sized widget. However, it misses simulating the long press gesture, which is the actual trigger for the crash described in the associated issue. I've added suggestions to complete the test by adding the long press action and also to improve code style by using const constructors.
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(LongPressDraggable<bool>)), Size.zero); |
There was a problem hiding this comment.
This test is intended to verify that LongPressDraggable doesn't crash in a zero-sized environment, as per the issue description. However, it only checks that the widget can be created with a zero size. It doesn't simulate a long press, which is the action that would trigger the crash.
To properly test the fix, you should simulate a long press gesture on the widget.
expect(tester.getSize(find.byType(LongPressDraggable<bool>)), Size.zero);
// This should not crash.
await tester.longPress(find.byType(LongPressDraggable<bool>));
await tester.pump();| feedback: Text('Y'), | ||
| child: Text('X'), |
There was a problem hiding this comment.
For better performance and to follow Dart best practices, it's recommended to use const for constructors of widgets that do not change, like Text with a constant string.
| feedback: Text('Y'), | |
| child: Text('X'), | |
| feedback: const Text('Y'), | |
| child: const Text('X'), |
1 participant
This is my attempt to handle #6537 for the LongPressDraggable widget.