Skip to content

fix(expect): adjust typings of *CalledWith matchers to allow a case there a mock was called with no arguments#12807

Merged
SimenB merged 2 commits into
jestjs:mainfrom
mrazauskas:fix-CalledWith-types
May 4, 2022
Merged

fix(expect): adjust typings of *CalledWith matchers to allow a case there a mock was called with no arguments#12807
SimenB merged 2 commits into
jestjs:mainfrom
mrazauskas:fix-CalledWith-types

Conversation

@mrazauskas

@mrazauskas mrazauskas commented May 4, 2022

Copy link
Copy Markdown
Contributor

Fixes #12804

Summary

As it was reported, typings of lastCalledWith, nthCalledWith, toBeCalledWith matchers should allow to test a case there a mock was called with no arguments:

test('mock called with no arguments', () => {
  mockFn();

  expect(mockFn).lastCalledWith();
  expect(mockFn).nthCalledWith(2);
  expect(mockFn).toBeCalledWith();
});

Test plan

Type tests are adjusted accordingly.

@mrazauskas mrazauskas changed the title fix(expect): improve types of *CalledWith matchers fix(expect): adjust typings of *CalledWith matchers to allow a case there a mock was called with no arguments May 4, 2022
SimenB
SimenB approved these changes May 4, 2022
View reviewed changes

@SimenB SimenB left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@SimenB SimenB merged commit a5bb884 into jestjs:main May 4, 2022
@mrazauskas mrazauskas deleted the fix-CalledWith-types branch May 4, 2022 14:31
@github-actions

github-actions Bot commented Jun 4, 2022

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in V28: [email protected] types toHaveBeenCalledWith forcing at least one argument.

3 participants

@mrazauskas @SimenB @facebook-github-bot