Skip to content

feat: add app render-process-gone event#24315

Merged
codebytere merged 1 commit into
9-x-yfrom
trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040
Jul 3, 2020
Merged

feat: add app render-process-gone event#24315
codebytere merged 1 commit into
9-x-yfrom
trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040

Conversation

@trop

@trop trop Bot commented Jun 26, 2020

Copy link
Copy Markdown
Contributor

Backport of #23560

See that PR for details.

Notes: Added new render-process-gone event on app to replace the renderer-process-crashed event.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jun 26, 2020
@trop
trop Bot requested a review from miniak June 26, 2020 15:31
@trop trop Bot mentioned this pull request Jun 26, 2020
6 tasks
@trop trop Bot added 9-x-y backport This is a backport PR labels Jun 26, 2020
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jun 27, 2020
@codebytere

Copy link
Copy Markdown
Member

@miniak the backport itself is approved by the Release WG, but we don't want to backport the deprecation until 10, so once it's removed we can merge this.

This is also failing relevant tests

@miniak
miniak force-pushed the trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040 branch from be6d55a to 627a4e6 Compare July 3, 2020 10:20
@miniak

miniak commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

@codebytere deprecation removed. The tests were failing because this PR depends on #24309

@codebytere
codebytere merged commit 4515c4d into 9-x-y Jul 3, 2020
@release-clerk

release-clerk Bot commented Jul 3, 2020

Copy link
Copy Markdown

Release Notes Persisted

Added new render-process-gone event on app to replace the renderer-process-crashed event.

@codebytere
codebytere deleted the trop/9-x-y-bp-feat-add-app-render-process-gone-event-1593185473040 branch July 3, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants