Skip to content

Update ktlint to 0.46.1 and remove support for older versions#1250

Merged
nedtwigg merged 6 commits intodiffplug:mainfrom
magneticflux-:issue-1239
Jun 30, 2022
Merged

Update ktlint to 0.46.1 and remove support for older versions#1250
nedtwigg merged 6 commits intodiffplug:mainfrom
magneticflux-:issue-1239

Conversation

@magneticflux-
Copy link
Copy Markdown
Contributor

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes its faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@nedtwigg nedtwigg enabled auto-merge June 30, 2022 18:12
@nedtwigg nedtwigg merged commit aa9bb11 into diffplug:main Jun 30, 2022
@nedtwigg
Copy link
Copy Markdown
Member

Released in plugin-gradle 6.8.0 and plugin-maven 2.23.0.

@magneticflux- magneticflux- deleted the issue-1239 branch May 18, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants