-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Configures workflow for offline unit tests #7512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@porfanid thanks for this PR. Can you share the motivation? Specifically, are you addressing some failure or missing functionality in your scenario? |
@porfanid - agreed with Tunji, we haven't run this test in a while, so we would ideally be refactoring it to run again. Are you trying to run with runners in your branch? Since these changes still look to be for the overall GH runner CI |
|
Hi @porfanid - following up on this? |
|
Hey @loadams and @sfc-gh-truwase , sorry for showing up late, I was having a lot of projects to work on. Well, I was thinking that because some tests required internet connection to run and the workers don't have internet access, they could not run. I actually don't know if the custom runners have internet access and I took a guess that they don't. |
@porfanid - the runners are connected to the network, they use the network to clone the git repo, pull packages, etc. Are you trying to run in your branch or what errors are you trying to resolve? |
|
I was trying to make the tests able to run on a github runner cause I don't have a custom runner to run those on. |
Sets up the environment for offline unit tests within the nightly workflow.