chore: remove flow check scripts#14785
Merged
Merged
Conversation
JLHwung
added
the
PR: Internal 🏠
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52594/ |
nicolo-ribaudo
approved these changes
Jul 23, 2022
liuxingbaoyu
approved these changes
Jul 23, 2022
JLHwung
commented
Jul 23, 2022
| env: { | ||
| node: true, | ||
| es2020: true, | ||
| es2022: true, |
Contributor
Author
There was a problem hiding this comment.
Per https://eslint.org/docs/latest/user-guide/configuring/language-options#specifying-environments, es2022: true implies parserOptions.ecmaVersion: 2022, so I removed the former option.
liuxingbaoyu
approved these changes
Jul 23, 2022
liuxingbaoyu
left a comment
liuxingbaoyu
left a comment
Member
There was a problem hiding this comment.
LGTM, just wait for the CI to go green.
nicolo-ribaudo
approved these changes
Jul 24, 2022
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow-binis removedRemoved flow check scripts now that we have converted the codebase to TypeScript.