Skip to content

fix: support string assertion key in assert entries #12281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLHwung merged 2 commits into from
Oct 29, 2020
Merged

fix: support string assertion key in assert entries #12281

JLHwung merged 2 commits into from
Oct 29, 2020

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 29, 2020 •
edited by gitpod-io bot
Loading

Q                       A
Fixed Issues? Babel throws for valid import "foo.js" assert { "type": "json" } (REPL)
Patch: Bug Fix? Y
License MIT

I am shocked that we don't have a test covering valid case import "foo.js" assert { "type": "json" }. This PR also disallows the following invalid cases:

import "foo" assert { type, "json" }
import "foo" \u{61}ssert { type: "json" }

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser Spec: Import Attributes labels Oct 29, 2020
@JLHwung JLHwung requested a review from sosukesuzuki October 29, 2020 17:27
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 29, 2020 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/31360/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 29, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16ec192:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

sosukesuzuki
sosukesuzuki reviewed Oct 29, 2020
View reviewed changes
sosukesuzuki
sosukesuzuki approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a typo! thanks!

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol 🙃

@JLHwung JLHwung merged commit 766df9c into babel:main Oct 29, 2020
@JLHwung JLHwung deleted the support-string-assertion-key branch October 29, 2020 19:10
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 4, 2020
Merged
sosukesuzuki added a commit to prettier/prettier that referenced this pull request Nov 6, 2020
@sosukesuzuki
Add tests for babel/babel#12281
1a2216d
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Import Attributes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JLHwung @babel-bot @existentialism @nicolo-ribaudo @sosukesuzuki