Adding clickable editorUrl from codeception.yml
#6261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes Codeception#6259 I followed the syntax of https://phpstan.org/user-guide/output-format#opening-file-in-an-editor even though we would need the second `%` here. (This is due to some phpstan internals, the code ultimately reads `\str_replace(['%file%', '%line%'], ...` But I'd say having an *identical* `editorUrl` syntax between Codeception and phpstan by far outweighs the "cost" of some unneeded `%` characters... ;-)
Naktibalda
requested changes
Oct 8, 2021
This was referenced Oct 30, 2021
Naktibalda
requested changes
Dec 11, 2021
Naktibalda
requested changes
Dec 11, 2021
Naktibalda
approved these changes
Dec 11, 2021
TavoNiievez
approved these changes
Dec 11, 2021
Member
|
@ThomasLandauer Could you document it in https://github.com/Codeception/codeception.github.com/blob/master/docs/reference/Configuration.md ? |
Member
Author
|
@Naktibalda Just noticed that all other config options are |
Member
|
I released it yesterday, but nobody will notice if we rename it quickly, right? |
Member
|
I raised #6303 |
Member
|
Renamed and released as 4.1.27 |
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6259
I followed the syntax of https://phpstan.org/user-guide/output-format#opening-file-in-an-editor even though we wouldn't need the second
%here. (This is due to some phpstan internals, the code ultimately reads\str_replace(['%file%', '%line%'], ...).But I'd say having an identical
editorUrlsyntax between Codeception and phpstan by far outweighs the "cost" of some unneeded%characters... ;-)$line = 0;is a fallback in case the trace iteration doesn't work out. I'm guessing that putting 1 for the line is better than leaving it empty.