avformat/mxfdec: Check that key was read sucessfull
authorMichael Niedermayer <[email protected]>
Sun, 11 Aug 2024 20:53:47 +0000 (22:53 +0200)
committerMichael Niedermayer <[email protected]>
Thu, 27 Feb 2025 16:53:16 +0000 (17:53 +0100)
Fixes: use of uninitialized value
Fixes: 70932/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-4870202133643264

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <[email protected]>
(cherry picked from commit 4c62cbcae2612acbc7ab5e8a7e7815674a6e8df4)
Signed-off-by: Michael Niedermayer <[email protected]>
libavformat/mxfdec.c

index a506a1635af89c224f71f006a1dec27ba7dbcf7b..a731ef71baefe08e9003e98294e8c0c29081d9c8 100644 (file)
@@ -1289,7 +1289,8 @@ static int mxf_read_indirect_value(void *arg, AVIOContext *pb, int size)
     if (size <= 17)
         return 0;
 
-    avio_read(pb, key, 17);
+    if (avio_read(pb, key, 17) != 17)
+        return AVERROR_INVALIDDATA;
     /* TODO: handle other types of of indirect values */
     if (memcmp(key, mxf_indirect_value_utf16le, 17) == 0) {
         return mxf_read_utf16le_string(pb, size - 17, &tagged_value->value);