fixed failed expectation source code line reporting because 12c repor…#332
Merged
Conversation
Pazus
commented
May 26, 2017
Pazus
commented
Member
- fixed the issue when line and package of expectation failed was not reported correctly
- enchanted for 12.2 as call_stack is provided with procedure level detals
…ts with procedure name
1 similar comment
jgebal
reviewed
May 27, 2017
| c_expectation_search_pattern constant varchar2(500) := '(.*\.UT_EXPECTATION_RESULT\s+)(.*\.UT_EXPECTATION[A-Z0-9#_$]*(\.\w+)?.*\s+)+(.*)\s'; | ||
| begin | ||
| l_caller_stack_line := regexp_substr( c_call_stack, c_expectation_search_pattern, 1, 1, 'm', 2); | ||
| --dbms_output.put_line(c_call_stack); |
jgebal
reviewed
May 27, 2017
jgebal
left a comment
jgebal
left a comment
Member
There was a problem hiding this comment.
Looks good, just two minor comments.
|
|
||
| @@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.AcceptsFileMapping.sql | ||
| @@lib/RunTest.sql ut_reporters/ut_coverage_sonar_reporter.BuildsSonarCoverageReport.sql | ||
| @@lib/RunTest.sql ut_reporters/ut_documentation_reporter.ProducesExpectedOutputs.sql |
Member
There was a problem hiding this comment.
maybe name the test: providesCorrectLineFromStacktrace?
jgebal
approved these changes
May 29, 2017
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.