Don't restrict object search to modules#9031
Merged
Merged
Conversation
I'm unsure why this change is here but I could find no equivalent logic in CRuby and this appears to prevent the search detailed in jruby#8924 from succeeding. Removing this restriction fixes that issue. Fixes jruby#8924
Member
Author
|
I traced this particular |
headius
force-pushed
the
also_search_object_for_classes
branch
from
4cee4de to
2a064ae
Compare
The final Object search should not be done when the target class descends from BasicObject instead of Object. We test this by checking its allocator against the default RubyBasicObject allocator.
headius
force-pushed
the
also_search_object_for_classes
branch
from
2a064ae to
f51a112
Compare
Member
Author
|
An additional patch here limits the Object search to only modules and classes that descend from Object, excluding BasicObject descendants. Without this, specs for jruby/spec/ruby/core/basicobject/basicobject_spec.rb Lines 18 to 20 in ff9277f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm unsure why this change is here but I could find no equivalent logic in CRuby and this appears to prevent the search detailed in #8924 from succeeding. Removing this restriction fixes that issue.
Fixes #8924