fix: properly close event loops in EventHolder and Observer#527
Merged
Conversation
- Add try-finally blocks to ensure event loops are closed after use - Fixes resource leak when creating new event loops - Applies cleanup to both EventHolder.py and Observer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
and Observer
Changes
EventHolder.py: Wraprun_until_completein try-finally toclose loop
Observer.py: Add finally block to close event loop after notifyWhy
When creating new event loops with
asyncio.new_event_loop(), theymust be explicitly closed to prevent resource leaks. The comment in
EventHolder.py referenced applying a fix from Observer.py, but
Observer.py also needed the same fix applied.