Message 62824 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	belopolsky, benjamin.peterson, loewis, vdupras
Date	2008-02-23.22:33:58
SpamBayes Score	0.028680256
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
Small comment on the patch: def clear(self): - for key in self.data.keys(): + for key in self.keys(): unsetenv(key) - del self.data[key] + del self[key] It looks like the patched version will unsetenv twice, Change del self[key] to dict.__delitem__(self, key) +1

Small comment on the patch:

                 def clear(self):
-                    for key in self.data.keys():
+                    for key in self.keys():
                         unsetenv(key)
-                        del self.data[key]
+                        del self[key]

It looks like the patched version will unsetenv twice, Change

del self[key]

to

dict.__delitem__(self, key)


+1

History
Date	User	Action	Args
2008-02-23 22:33:59	belopolsky	set	spambayes_score: 0.0286803 -> 0.028680256 recipients: + belopolsky, loewis, benjamin.peterson, vdupras
2008-02-23 22:33:59	belopolsky	set	spambayes_score: 0.0286803 -> 0.0286803 messageid: <[email protected]>
2008-02-23 22:33:58	belopolsky	link	issue2144 messages
2008-02-23 22:33:58	belopolsky	create