Skip to content

Update some libs & tests to 3.14.3#7148

Merged
youknowone merged 5 commits intoRustPython:mainfrom
ShaharNaveh:update-libs-1
Feb 15, 2026
Merged

Update some libs & tests to 3.14.3#7148
youknowone merged 5 commits intoRustPython:mainfrom
ShaharNaveh:update-libs-1

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Feb 14, 2026

Summary by CodeRabbit

  • Refactor
    • Optimized internal error handling logic in cryptographic operations for improved code efficiency.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

Refactors error handling in PBKDF2 HMAC dklen length conversion by replacing a two-step map_err closure with a single, more concise implementation. Functional behavior and control flow remain unchanged.

Changes

Cohort / File(s) Summary
Error Handling Refactoring
crates/stdlib/src/hashlib.rs
Simplifies map_err closure for dklen length conversion in PBKDF2 HMAC computation, reducing from two-step to single-step closure while preserving overflow error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop and a skip through error code, ✨
One closure now where two paths strode,
PBKDF2 whispers thanks with glee,
Concise and clean—thumps bunny feet! 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Update some libs & tests to 3.14.3' is unrelated to the actual changeset, which focuses on optimizing PBKDF2 HMAC error handling in hashlib, not updating library versions. Update the title to reflect the actual change, such as 'Simplify PBKDF2 HMAC error handling in hashlib' or 'Optimize dklen validation error path in hashlib'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Code has been automatically formatted

The code in this PR has been formatted using:

  • cargo fmt --all
    Please pull the latest changes before pushing again:
git pull origin update-libs-1

@github-actions
Copy link
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/mailbox.py
[x] test: cpython/Lib/test/test_mailbox.py

dependencies:

  • mailbox

dependent tests: (2 tests)

  • mailbox: test_genericalias test_mailbox

[x] test: cpython/Lib/test/test_binascii.py (TODO: 1)

dependencies:

dependent tests: (42 tests)

  • binascii: test_base64 test_binascii test_ctypes test_hashlib test_hmac test_plistlib test_zlib
    • base64: test_email test_gettext test_httpservers test_smtplib test_urllib2_localnet test_xmlrpc test_zoneinfo
      • secrets: test_secrets
      • smtplib: test_smtpnet
      • ssl: test_ssl
      • urllib.request: test_http_cookiejar test_pathlib test_pydoc test_site test_urllib test_urllib2 test_urllib2net test_urllibnet
    • email: test_email test_mailbox
      • http.client: test_docxmlrpc test_ucn test_unicodedata test_wsgiref
      • http.server: test_logging test_robotparser
      • importlib.metadata: test_importlib
      • mailbox: test_genericalias
    • imaplib: test_imaplib
    • zipfile: test_pkgutil test_shutil test_zipapp test_zipfile test_zipfile64 test_zipimport

[x] lib: cpython/Lib/pyclbr.py
[ ] test: cpython/Lib/test/test_pyclbr.py (TODO: 2)

dependencies:

  • pyclbr

dependent tests: (1 tests)

  • pyclbr: test_pyclbr

[x] lib: cpython/Lib/xmlrpc
[x] test: cpython/Lib/test/test_xmlrpc.py (TODO: 5)
[x] test: cpython/Lib/test/test_docxmlrpc.py

dependencies:

  • xmlrpc

dependent tests: (2 tests)

  • xmlrpc: test_docxmlrpc test_xmlrpc

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@youknowone youknowone merged commit 1adf925 into RustPython:main Feb 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants