Open
Conversation
Member
|
@copilot how can i run CI for this patch? |
Contributor
|
@youknowone I've opened a new pull request, #7133, to work on those changes. Once the pull request is ready, I'll request review from you. |
Member
|
@copilot rebase this branch to upstream/main and fix the Ci failure |
4 tasks
Contributor
|
@youknowone I've opened a new pull request, #7140, to work on those changes. Once the pull request is ready, I'll request review from you. |
b86926d to
645e217
Compare
Contributor
Author
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin main-c416cc8bbeaea03f |
Contributor
Author
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/hmac.py dependencies:
dependent tests: (4 tests)
Legend:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
hmacfrom CPython v3.14.3.Part of #6839
Changes
Lib/hmac.pyfrom CPython (added 1 line)@expectedFailureTest Results
The upgrade introduces 5 new test classes related to OpenSSL implementation:
OpenSSLConstructorTestCase.test_constructor_unknown_digestmodOpenSSLConstructorTestCase.test_constructor_missing_digestmodOpenSSLConstructorTestCase.test_constructorOpenSSLConstructorTestCase.test_hmac_digest_digestmod_parameterOpenSSLUpdateTestCase.test_updateThese tests are marked as expected failures as they require OpenSSL-specific functionality not yet implemented in RustPython.