Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if other.class().is(vm.ctx.types.dict_type) | ||
| && let Ok(other) = other.downcast::<PyDict>() |
There was a problem hiding this comment.
still there is convenience problem, but we have downcast_exact
| } | ||
|
|
||
| // ============================================================================ | ||
| // OrderedDict implementation |
There was a problem hiding this comment.
If this type is comparably big to this module crates/vm/src/stdlib/collections/ordered_dict.rs?
2 participants
This pull request will resolve some parts of #3418. I need to review these code again 🔨