Fix Swift 6 concurrency warnings and cleanup Keychain API#251
Merged
MaatheusGois merged 2 commits intomainfrom Feb 12, 2026
Merged
Conversation
This PR resolves all Swift 6 strict concurrency warnings and cleans up the public API by making the embedded KeychainAccess library internal. Changes: - Fixed Sendable concurrency issues in CustomAuthenticationExample by using lazy var and @unchecked Sendable - Fixed unused expression warning in Resources.Files.Controller - Added @sendable annotations to all completion handlers in KeychainService - Changed Keychain class and related types from public to internal to avoid API pollution All tests pass (41 tests in 8 suites).
Generated by 🚫 Danger Swift against 38d2eb9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves all Swift 6 strict concurrency warnings and cleans up the public API by making the embedded KeychainAccess library internal.
Changes
Swift 6 Concurrency Fixes
CustomAuthenticationExample.swift
sessionfrom mutablevartolazy varto resolve Sendable conformance issues@unchecked Sendableconformance to the class@Sendableannotations from URLSessionDelegate completion handlers to match protocol requirementsKeychainService.swift
@Sendableannotations to all completion handler parametersResources.Files.Controller.swift
_API Cleanup
Keychainclass frompublictointernalinternal:ItemClass,ProtocolType,AuthenticationType,Accessibility,AuthenticationUI,AuthenticationPolicyTesting
Impact